[Add] IEquatable to Signer
#3571
Conversation
|
|
||
| public override bool Equals(object obj) | ||
| { | ||
| if (obj == null) |
There was a problem hiding this comment.
== null already done in is sentence
There was a problem hiding this comment.
== checks for null and sends to this method.
| if (other is null) return false; | ||
| return Account == other.Account && | ||
| Scopes == other.Scopes && | ||
| AllowedContracts.SequenceEqual(other.AllowedContracts) && |
There was a problem hiding this comment.
Some of these values are null depending of the Scope
There was a problem hiding this comment.
scope can not be null, its a enum, can not be null.
There was a problem hiding this comment.
scope can not be null,
But AllowedContracts/AllowedGroups/Rules can be null sometimes, that's what Shargon says.
There was a problem hiding this comment.
Yes, some of the values can be null, we should make unit tests with real signers with different scopes, depending of the scope, you will find nulls entries
There was a problem hiding this comment.
use Xxxs.AsSpan().SequenceEqual(other.AsSpan()) instead.
SequenceEqual in System.MemoryExtensions is null safe.
| if (other is null) return false; | ||
| return Account == other.Account && | ||
| Scopes == other.Scopes && | ||
| AllowedContracts.SequenceEqual(other.AllowedContracts) && |
There was a problem hiding this comment.
scope can not be null,
But AllowedContracts/AllowedGroups/Rules can be null sometimes, that's what Shargon says.
| @@ -66,6 +67,31 @@ public class Signer : IInteroperable, ISerializable | |||
| /*AllowedGroups*/ (Scopes.HasFlag(WitnessScope.CustomGroups) ? AllowedGroups.GetVarSize() : 0) + | |||
| /*Rules*/ (Scopes.HasFlag(WitnessScope.WitnessRules) ? Rules.GetVarSize() : 0); | |||
|
|
|||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | |||
| public bool Equals(Signer other) | |||
There was a problem hiding this comment.
Is there a practical need for this API?
There was a problem hiding this comment.
those of being nulls will also be compared, i have checked, null == null return true. Not sure if this can be of any problem, looks right to me.
There was a problem hiding this comment.
Is not bad to me also, == and != not required to me, but it's ok
Change Log
IEquatabletoSignerclassIEquatableonSignerclassNeeds #3573
Type of change
How Has This Been Tested?
Test_IEquatableTest Configuration:
Checklist: